refactor(application-header): convert inlineDropdown to a signal#2179
refactor(application-header): convert inlineDropdown to a signal#2179spike-rabbit wants to merge 1 commit into
Conversation
spike-rabbit
force-pushed
the
refactor/application-header-inline-dropdown-signal
branch
from
bc309a8 to
cbe6230
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the application header, collapsible actions, and dropdown trigger components to use Angular Signals instead of RxJS Observables for the inlineDropdown state. The review feedback highlights that using effect() to propagate state changes violates Rule 38 of the Repository Style Guide, which can cause ExpressionChangedAfterItHasBeenChecked errors and performance issues. It is recommended to replace these continuous effects with on-demand RxJS subscriptions using toObservable when the menus or dropdowns are actually open, along with cleaning up unused imports and adding the necessary RxJS operators.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
spike-rabbit
force-pushed
the
refactor/application-header-inline-dropdown-signal
branch
2 times, most recently
from
7ed3cf5 to
e44910f
Compare
|
the gemini feedback is entirely pointless |
Replace the `inlineDropdown` Observable with a signal across the application-header. This allows easier usage, especially in host attributes which we need to enhance a11y in a future PR.
spike-rabbit
force-pushed
the
refactor/application-header-inline-dropdown-signal
branch
from
e44910f to
638621e
Compare
1 participant
Replace the
inlineDropdownObservable with a signal across the application-dropdown system.This allows easier usage, especially also in host attributes which we will need to enhance a11y in a future PR.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: